Improve warning of no logs when using filter for logs list (#733)

auth0 · Apr 13, 2023 · 59a0cad · 59a0cad
1 parent c311de4
commit 59a0cad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/internal/cli/logs.go b/internal/cli/logs.go
@@ -66,7 +66,8 @@ func listLogsCmd(cli *cli) *cobra.Command {
 				return fmt.Errorf("An unexpected error occurred while getting logs: %v", err)
 			}
 
-			cli.renderer.LogList(list, !cli.debug)
+			hasFilter := inputs.Filter != ""
+			cli.renderer.LogList(list, !cli.debug, hasFilter)
 			return nil
 		},
 	}

diff --git a/internal/display/logs.go b/internal/display/logs.go
@@ -142,13 +142,18 @@ func (v *logView) typeDesc() (typ, desc string) {
 	return typ, desc
 }
 
-func (r *Renderer) LogList(logs []*management.Log, silent bool) {
+func (r *Renderer) LogList(logs []*management.Log, silent, hasFilter bool) {
 	resource := "logs"
 
 	r.Heading(resource)
 
 	if len(logs) == 0 {
-		r.EmptyState(resource)
+		if hasFilter {
+			r.Output("No logs available matching filter criteria.\n\n")
+		} else {
+			r.EmptyState(resource)
+		}
+
 		r.Infof("To generate logs, run a test command like 'auth0 test login' or 'auth0 test token'")
 		return
 	}