Refactor broadcast receiver usage #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
commented
Apr 27, 2021
Widcket
previously approved these changes
Apr 27, 2021
Widcket
previously approved these changes
Apr 28, 2021
auto-merge was automatically disabled
April 28, 2021 15:34
Rebase failed
lbalmaceda
force-pushed
the
fix-broadcast
branch
from
353cb67 to
5b7f42d
Compare
Widcket
approved these changes
Apr 28, 2021
lbalmaceda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The broadcast receiver that handles events was being registered right after the lock widget
Builderwas built. This is because the lock instance is meant to be created once and reused. And while this instance is meant to be released in the (dev's)activity#onDestroy()method, this wasn't consistently documented across the readme.Calling multiple times
builder#build(context)like we used to do in our demo app before this PR, would cause multiple different broadcast receiver instances to be registered. Then the callback would be invoked multiple times after each event.The right way to clear up resources and broadcast receiver registrations is via the
lock#onDestroy(context).References
Fixes #607
Testing
This part of the code is not unit-tested.