Bugfix #581 | Fix social login buttons with white backgrounds #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganlutz
commented
Jun 30, 2020
| final ShapeDrawable pressedBackground; | ||
|
|
||
| boolean shouldDrawOutline = pressedColor == Color.WHITE; | ||
| if (shouldDrawOutline) { | ||
| int outlineColor = getResources().getColor(R.color.com_auth0_lock_social_light_background_focused); | ||
| normalBackground = ViewUtils.getRoundedOutlineBackground(getResources(), outlineColor); | ||
| normalBackground = ViewUtils.getOpaqueRoundedOutlineBackground(getResources(), pressedColor, outlineColor); |
There was a problem hiding this comment.
@lbalmaceda I left this the same because the auth config background color is being passed to getTouchFeedbackBackground which is then used for this new method
lbalmaceda
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See #581
Testing
You can test this change in dark mode by adding this line in the app level
colors.xmlfile:This change adds unit test coverageThis change adds integration/UI test coverageI did not see unit or integration tests for the existing social button methods.
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors
The correct base branch is being used