Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update username regex to allow special chars #544

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Update username regex to allow special chars #544

merged 1 commit into from
Jul 19, 2019

Conversation

lbalmaceda
Copy link
Contributor

Changes

Adds support for new special characters are allowed to be used on database connections username field.

References

As defined in https://auth0.com/docs/connections/database/require-username

Testing

No unit tests!

  • This change adds unit test coverage

  • This change adds integration/UI test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added this to the v2-Next milestone Jul 19, 2019
@lbalmaceda lbalmaceda requested a review from a team July 19, 2019 19:57
@damieng damieng self-assigned this Jul 19, 2019
damieng
damieng approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested various valid and non-valid combinations in the online regex tester too.

@lbalmaceda lbalmaceda merged commit 7ab8b5a into master Jul 19, 2019
@lbalmaceda lbalmaceda deleted the username-regex branch July 19, 2019 20:37
@lbalmaceda lbalmaceda modified the milestones: v2-Next, 2.15.0 Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees

@damieng damieng

Labels
CH: Changed tiny Tiny review
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lbalmaceda @damieng