Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse 'password_leaked' error message #522

Merged
merged 3 commits into from
Feb 22, 2019
Merged

Parse 'password_leaked' error message #522

merged 3 commits into from
Feb 22, 2019

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Feb 22, 2019

Add the ability to parse password_leaked errors returned by the backend. This is currently handled in a generic way, displaying a default error message when this case happens.

If this PR gets merged, the error would look like this instead:
image

Copy subject to change and open to suggestions :)

The string resource can be overwritten by defining your own string resource using the very same key.

@lbalmaceda lbalmaceda added this to the v2-Next milestone Feb 22, 2019
@lbalmaceda
Copy link
Contributor Author

Changed the copy as suggested internally
image

@lbalmaceda lbalmaceda merged commit fb9b98a into master Feb 22, 2019
@lbalmaceda lbalmaceda modified the milestones: v2-Next, 2.12.1 Feb 22, 2019
@lbalmaceda lbalmaceda deleted the patch-pwd-leaked branch February 22, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants