Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non touchscreen navigation #444

Merged
merged 20 commits into from
Oct 12, 2017
Merged

Fix non touchscreen navigation #444

merged 20 commits into from
Oct 12, 2017

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Oct 6, 2017 •
edited
Loading

  • Make all View components focusable
  • Check d-pad navigation works as expected
  • Improve visual feedback of the current component in focus

PR Result: http://g.recordit.co/ihm00lATqb.gif

@lbalmaceda lbalmaceda added this to the v2-Next milestone Oct 6, 2017
@lbalmaceda lbalmaceda force-pushed the attempt-to-fix-non-touchscreen-navigation branch from 504858d to f5745d7 Compare October 6, 2017 22:26
@lbalmaceda lbalmaceda force-pushed the attempt-to-fix-non-touchscreen-navigation branch from f5745d7 to a4304ac Compare October 6, 2017 22:29
@lbalmaceda lbalmaceda force-pushed the attempt-to-fix-non-touchscreen-navigation branch from 1b84773 to 6261ba9 Compare October 11, 2017 20:43
cocojoe
cocojoe approved these changes Oct 12, 2017
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is mostly drawing stuff, so judging by the video it looks good.

@lbalmaceda lbalmaceda merged commit d756e46 into master Oct 12, 2017
@lbalmaceda lbalmaceda deleted the attempt-to-fix-non-touchscreen-navigation branch October 12, 2017 12:45
@lbalmaceda lbalmaceda mentioned this pull request Oct 12, 2017
Closed
@lbalmaceda lbalmaceda modified the milestones: v2-Next, 2.8.0 Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocojoe cocojoe cocojoe approved these changes

@aaguiarz aaguiarz Awaiting requested review from aaguiarz

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lbalmaceda @cocojoe