Request the user to accept Terms&Policy before Sign Up #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
force-pushed
the
must-accept-terms
branch
from
c105e7b to
d7a6b06
Compare
| public void shouldNotSetTermsOfServiceURLWhenInvalidURL() { | ||
| Options options = new Options(); | ||
| options.setAccount(auth0); | ||
| public void shouldNotSetTermsOfServiceURLWhenInvalidURL() throws Exception { | ||
| options.setTermsURL("an-invalid/url"); |
There was a problem hiding this comment.
slightly OT but shouldn't this throw IAE instead of leaving a null value ?
There was a problem hiding this comment.
If the given url it's not valid, the it will default to Auth0's terms/policy urls. I was trying to avoid throwing an exception at this point, and just warning the user that the default will be used on the LogCat. Anyway, I can add that change.
lbalmaceda
force-pushed
the
must-accept-terms
branch
from
bc77805 to
d6e20ad
Compare
lbalmaceda
force-pushed
the
must-accept-terms
branch
from
d6e20ad to
ff2a19e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects database connections only. The dev must set the option on the builder first:
When he completes the fields with valid data and press the submit button, a dialog will prompt asking for acceptance.