Refactor Custom Fields flow #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lbalmaceda
commented
Jun 8, 2016
lbalmaceda
commented
- If the custom fields are less or equal than 2, they are shown in the "first" sign up screen. If they are more, the "second" screen will show all of them.
- Consider "error" and "code" keys when parsing login errors.
- Username Style properly handled.
lbalmaceda
force-pushed
the
refactor-custom-fields-screens
branch
2 times, most recently
from
1700f9d to
fe1c959
Compare
| return event; | ||
| } else if (lockWidget.getConfiguration().hasExtraFields()) { |
lbalmaceda
force-pushed
the
refactor-custom-fields-screens
branch
from
fe1c959 to
f8a38ca
Compare
lbalmaceda
force-pushed
the
refactor-custom-fields-screens
branch
from
f8a38ca to
419e601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.