Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swift Package Manager Support [SDK-1181] #97

Merged
merged 4 commits into from
Nov 26, 2019
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 21, 2019

Changes

This PR adds support for Swift Package Manager. There was a PR by @ned1988 that broke Carthage support.

References

Original PR will be closed #96
Fixes #92

Testing

The changes were tested manually for each package manager (SPM, CocoaPods and Carthage) by adding the framework to a new application, importing and calling the decode(jwt:) method.

Test environment

  • Xcode 11.2.1 (11B500)
  • iOS 13.2.2 (Simulators)
  • Carthage 0.34.0
  • CocoaPods 1.8.4
  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added this to the vNext milestone Nov 21, 2019
@Widcket Widcket requested a review from a team November 21, 2019 21:13
This was referenced Nov 26, 2019
@cocojoe cocojoe changed the title Added Swift Package Manager Support Added Swift Package Manager Support [SDK-1136] Nov 26, 2019
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package questions

Package.resolved Show resolved Hide resolved
@Widcket Widcket requested a review from cocojoe November 26, 2019 12:15
@cocojoe cocojoe changed the title Added Swift Package Manager Support [SDK-1136] Added Swift Package Manager Support [SDK-1181] Nov 26, 2019
@Widcket Widcket merged commit 230136d into master Nov 26, 2019
@Widcket Widcket deleted the feature/spm-support branch November 26, 2019 13:02
@Widcket Widcket mentioned this pull request Nov 27, 2019
@Widcket Widcket mentioned this pull request Dec 20, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift Package Manger support?
3 participants