Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Swift #5

Merged
merged 7 commits into from
Jun 26, 2015
Merged

Migrate to Swift #5

merged 7 commits into from
Jun 26, 2015

Conversation

hzalaz
Copy link
Member

@hzalaz hzalaz commented Jun 25, 2015

No description provided.

@hzalaz hzalaz force-pushed the feature-swift-migration branch 7 times, most recently from 654a72a to 1fe25dc Compare June 25, 2015 21:24
@hzalaz hzalaz force-pushed the feature-swift-migration branch from f826a11 to 9d202b0 Compare June 26, 2015 15:31
hzalaz added a commit that referenced this pull request Jun 26, 2015
@hzalaz hzalaz merged commit 55386ce into master Jun 26, 2015
@hzalaz hzalaz deleted the feature-swift-migration branch June 26, 2015 15:36
@billinghamj
Copy link

Why on earth did you move this library to Swift in a without the semver version to indicate a breaking change?!

It also seems strange to not change the name of the pod. It is effectively a completely different library now.

While it may be compatible with Obj-C, I don't want my app's size to quadruple because you decided to dump the Swift runtime into my app without telling me!

@billinghamj
Copy link

Never mind, I see that it actually was indicated as a breaking change.

Are you planning on maintaining the 0.2.x branch?

@hzalaz
Copy link
Member Author

hzalaz commented Nov 11, 2015

@billinghamj if there are some issues I'll release the proper fixes but we are not planning to add any more features, actually the swift branch won't get a lot more since the only thing missing is signature validation and for now that's not the purpose of the library.

Feel free to submit any issue you find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants