Use password-realm grant for /oauth/token endpoint #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzalaz
suggested changes
Dec 21, 2016
| @@ -104,6 +106,16 @@ public ParameterBuilder setConnection(String connection) { | |||
| } | |||
|
|
|||
| /** | |||
| * Sets the 'realm' parameter | |||
There was a problem hiding this comment.
Let's explain better what the realm is
| @Override | ||
| public SignUpRequest setRealm(String realm) { | ||
| signUpRequest.setConnection(realm); | ||
| authenticationRequest.setRealm(realm); |
There was a problem hiding this comment.
And for connection? also if we are not using the proper grant (e.g. when working with the legacy endpoints) what will happen?. If we quietly ignore them we should at least issue a warning in the logs
hzalaz
approved these changes
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login using
/oauth/tokenendpoint was sendinggrant_type = 'password'which was wrong. This PR fixes that and also allows theAuthenticationRequestto specify a realm value.