Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with custom domains in appliance #216

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

mcastany
Copy link
Contributor

✏️ Changes

Custom domains in appliance was not working (reported by a customer). The appliance has some settings that are different from cloud which made it difficult to troubleshoot.

Issue:

That mismatch configuration was causing the extension to fail to authenticate the user, throwing the reported error here - https://github.com/mcastany/auth0-delegated-administration-extension/blob/master/server/lib/middlewares/requireScope.js#L6

🎯 Testing

✅This change has been tested in a Webtask
🚫This change has unit test coverage
🚫This change has integration test coverage
🚫This change has been tested for performance

🚀 Deployment

Can this change be merged at any time? What will the deployment of the change look like? Does this need to be released in lockstep with something else?

✅This can be deployed any time

@mcastany mcastany merged commit d106a3c into auth0-extensions:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants