ESD-3554 - Add optional client option to password reset dialog #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongodin
approved these changes
Jan 8, 2020
yacineMTB
reviewed
Jan 8, 2020
| }; | ||
|
|
||
| shouldComponentUpdate(nextProps) { | ||
| return nextProps.passwordReset !== this.props.passwordReset || | ||
| nextProps.languageDictionary !== this.props.languageDictionary | ||
| nextProps.languageDictionary !== this.props.languageDictionary || | ||
| // nextProps.settings !== this.props.settings || |
There was a problem hiding this comment.
Did you mean to leave this comment?
There was a problem hiding this comment.
👋 Hi @yacineMTB , that's a part of the revert I made to the version with client_id selector: https://github.com/auth0-extensions/auth0-delegated-administration-extension/pull/200/files#diff-e88409dcf3bfb8a19e35f37b563d6a55L46
mcastany
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
This PR introduces the client option back to the password reset dialog. It is optional.
📷 Screenshots
Before:
After:
PW Reset Request in the logs w/ and wo/ selecting a client:
Two different PW reset emails due to different client chosen:
HTTP requests to the extension w/ and wo/ selecting a client on the UI:
🔗 References
https://auth0team.atlassian.net/browse/ESD-3554
#200
🎯 Testing
🚫 This change has been tested in a Webtask
✅ This change has been tested locally
✅This change has unit test coverage
🚫 This change has integration test coverage
🚫 This change has been tested for performance
🚀 Deployment
✅This can be deployed any time
🎡 Rollout
In order to verify that the deployment was successful we will see the optional client selection on the PW reset modal. We'll not select a client and it'll send a pw reset email. We'll select a client and it'll send a pw reset email.
🔥 Rollback
We will rollback if we start getting 500s.
📄 Procedure
Revert the PR.
🖥 Appliance
✅ It is compatiable.