Skip to content

Commit

Permalink
Fixes to postgres methods
Browse files Browse the repository at this point in the history
Don't lower-case table names
Put double quotes around table name in copy statement
  • Loading branch information
austinweisgrau committed Sep 21, 2024
1 parent bdc25d4 commit 76f62da
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion parsons/databases/postgres/postgres.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def copy(
self.query_with_connection(sql, connection, commit=False)
logger.info(f"{table_name} created.")

sql = f"""COPY {table_name} ("{'","'.join(tbl.columns)}") FROM STDIN CSV HEADER;"""
sql = f"""COPY "{table_name}" ("{'","'.join(tbl.columns)}") FROM STDIN CSV HEADER;"""

with self.cursor(connection) as cursor:
cursor.copy_expert(sql, open(tbl.to_csv(), "r"))
Expand Down
4 changes: 2 additions & 2 deletions parsons/databases/postgres/postgres_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,9 @@ def table_exists_with_connection(self, table_name, connection, view=True):
# Extract the table and schema from this. If no schema is detected then
# will default to the public schema.
try:
schema, table = table_name.lower().split(".", 1)
schema, table = table_name.split(".", 1)
except ValueError:
schema, table = "public", table_name.lower()
schema, table = "public", table_name

with self.cursor(connection) as cursor:
# Check in pg tables for the table
Expand Down

0 comments on commit 76f62da

Please sign in to comment.