Chore: Refactore EVM ExitFatal reason #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksuss
approved these changes
Jul 5, 2024
birchmd
approved these changes
Jul 5, 2024
github-merge-queue bot
pushed a commit
to aurora-is-near/aurora-engine
that referenced
this pull request
Aug 27, 2024
### Description To be fully compatible with EVM, we should: :arrow_right: Success| Revert :arrow_right: ExitError - Execution errors should charge gas from users :arrow_right: ExitFatal - shouldn't charge user gas :arrow_right: Transactions validation errors should not charge user gas This PR changed the logic for EVM exit reason gas charge for users, which includes EVM execution errors gas charge. Previously transaction just panicked, and user's gas was not charged. #### EVM Related to EVM changes: aurora-is-near/sputnikvm/pull/52 --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
aleksuss
added a commit
to aurora-is-near/aurora-engine
that referenced
this pull request
Oct 10, 2024
### Description To be fully compatible with EVM, we should: :arrow_right: Success| Revert :arrow_right: ExitError - Execution errors should charge gas from users :arrow_right: ExitFatal - shouldn't charge user gas :arrow_right: Transactions validation errors should not charge user gas This PR changed the logic for EVM exit reason gas charge for users, which includes EVM execution errors gas charge. Previously transaction just panicked, and user's gas was not charged. #### EVM Related to EVM changes: aurora-is-near/sputnikvm/pull/52 --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored EVM
ExitFatalreason for only Fatalcases.➡️ Moved
ExitFatal::UsizeOverflowtoExitError::UsizeOverflowas it's notFatalcase for EVM exit.Compatability
ExitReason.