Fix: use single crate for borsh version, allow to choose borsh v0.9 for all crates #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
added
the
C-dependencies
birchmd
requested review from
RomanHodulak,
aleksuss,
vimpunk and
joshuajbouw
as code owners
vimpunk
approved these changes
May 31, 2023
aleksuss
approved these changes
May 31, 2023
joshuajbouw
approved these changes
May 31, 2023
…needed to make CI pass due to a recent change in the OpenZeppelin repo
birchmd
added a commit
that referenced
this pull request
Jun 22, 2023
…or all crates (#767) ## Description [Near Workspaces](https://crates.io/crates/workspaces) still uses `borsh` version 0.9. Therefore we need the `borsh-compat` feature on all our crates that use `borsh` if we want to use them in Workspaces-based tests. This PR makes this change. This is a non-functional change (impacts only a dependency version and only if a feature is specified), therefore has no impact on tests or performance.
mrLSD
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Near Workspaces still uses
borshversion 0.9. Therefore we need theborsh-compatfeature on all our crates that useborshif we want to use them in Workspaces-based tests. This PR makes this change.This is a non-functional change (impacts only a dependency version and only if a feature is specified), therefore has no impact on tests or performance.