Feat(exit precompiles): Include sender field in exit precompile events #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paouvrard
approved these changes
Oct 4, 2021
sept-en
approved these changes
Oct 4, 2021
birchmd
added a commit
to birchmd/aurora-engine
that referenced
this pull request
Oct 4, 2021
This was referenced Oct 8, 2021
Merged
artob
pushed a commit
that referenced
this pull request
Oct 15, 2021
* Feat(exit precompile): Events for exit precompile calls. (#288) * Bump path-parse from 1.0.6 to 1.0.7 in /etc/eth-contracts (#229) * Include sender field in exit precompile events (#292) * Feat(tests): ecpair (#296) * Feat(tests): Uniswap V3 tests and benchmarks (#293) * Feat(tests): deploying the largest allowed contract (#294) * Fix(precompiles): Derive Default impl for PrecompileOutput (#295) * Feat(docs): Benchmark documentation (#298) Co-authored-by: Michael Birch <michael@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #288 addressing @paouvrard's comment about including the sender field in the event because it is meaningful in the ETH exit case, even if it is not in the ERC-20 case.