Release 1.6.4 #285
Release 1.6.4 #285
Conversation
* A test showing a 1inch liquidity pool working * Add some modules to organize 1inch code * Reorganize code; add gas value asserts * Avoid some code duplication
…ites data to the created account code) (#277)
#275) Bumps [@openzeppelin/contracts](https://github.com/OpenZeppelin/openzeppelin-contracts) from 4.3.1 to 4.3.2. - [Release notes](https://github.com/OpenZeppelin/openzeppelin-contracts/releases) - [Changelog](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/CHANGELOG.md) - [Commits](OpenZeppelin/openzeppelin-contracts@v4.3.1...v4.3.2) --- updated-dependencies: - dependency-name: "@openzeppelin/contracts" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Introduce workspace * Split to crate: * engine * prelude * sdk * Fixed tests * Refactored dependencies to new crates Co-authored-by: Michael Birch <michael.birch@aurora.dev>
|
@birchmd From a source code perspective, it's can be version 1.6.4. It should be 1.7.0 - because of breaking changes in source code. |
|
As I understand it, our product is the (wasm) contract we deploy to Near and this is what the version refers to. Source code organization changes (even large ones like spitting into multiple crates) are not observable from the contract perspective. The only important change is the |
There was a problem hiding this comment.
This looks good to me. There are some small nits that I do notice such as the libs IMO shouldn't be prefixed with engine- but, that's ok for now. Everything else and running it on my end looks good.
To be fair, we should be bumping every major version every time we break public API. We are still technically beta, although the version says otherwise. Bumping minor, in this case, should be fine then.
But, if the API isn't correct and producing something unintentionally, that can be considered a bug.
birchmd
force-pushed
the
release-1.6.4
branch
from
72d5575
to
791795c
Compare
Correct. We follow semantic versioning, and the versioning scheme is quite systematic and predictable. |
* Split to crates: engine, prelude, sdk (#243) * Test for 1inch liquidity protocol (#274) * Bump @openzeppelin/contracts from 4.3.1 to 4.3.2 in /etc/eth-contracts (#275) * Fix deploy benchmark to use a realistic transaction (that actually writes data to the created account code) (#277) * Fix json formatting in JsonValue serialization (#279) * Update primitive-types dependency to 0.10 (#280) * Fix block.timestamp (#287) Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ft_metadatabug fix (Fix json formatting in JsonValue serialization #279)