[WIP] Fix bauhaus widgets interaction #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the "no color space" option use the embedded profile if any
1. remove an useless param commiting on button_pressed that duplicated button_released, 2. remove param commiting on motion_notify, only update the slider coordinate and redraw the widget 3. simplify the dragging event handling sequence 4. drag and drop as well as clicks trigger a params commit and a pipeline recompute only on button_released 5. introduce a debug parameter "gui" printing the sequence of bauhaus widget execution Result : sliders feel snappier in GUI TODO: continue with slider scrolling events and comboboxes
Wait for the final button release to update slider values, instead of commiting on each motion_notifiy event. It saves many intermediate pipeline recomputes.
1. remove support for curve callback, incomplete, complicated, duplicated and silently bugged (no support in popups, but used only in 2 ashift for parameters auto-set in most cases) 2. create an uniform slider setting function from GUI, normalized with widget width 3. disambiguate the curront slider setting function, normalized with range min/max, working from parameter value
|
SonarCloud Quality Gate failed.
|
|
Superseded by 48a86a9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29