forked from edgardoh/darktable
-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Raster masks broken #396
Labels
Milestone
Comments
Could you send the picture + XMP please ? |
Uploaded to your private cloud, files-for-issue-396.zip |
Reproduced |
aurelienpierre
added a commit
that referenced
this issue
Jan 10, 2025
Remove inline loops and complicated branching to make the sequence more legible. Layout the ground work to troubleshoot #396 and possibly share code between GUI pipelines.
Ok the issue is more simple. Raster masks are broken. |
aurelienpierre
changed the title
Bug: Jpeg export is wrong, mask error
Bug: Raster masks broken
Jan 10, 2025
aurelienpierre
added a commit
that referenced
this issue
Jan 11, 2025
…masks from DB It's confusing because (parametric) blending operations are fetched in the same SQL query as module params, but masks are not. They have their own method and their own SQL query that needs to update the existing history stack. So we just need to commit blendops (including raster masks) after that step of history fetching. Fix Bug: Raster masks broken #396
Fixed by cf52835 |
github-project-automation
bot
moved this from Todo
to Done
in Ansel development management
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search previous report
Computer's operating system
Linux
What GPU do you have ?
No GPU
Ansel version
Ansel-0.0.0+980~ga329ee63-x86_64.AppImage
Type of binary
Pre-built packages provided by the Ansel project (.AppImage, .EXE)
What happened?
I've been working on a photo with Exposure masks which are re-used later in the pipe. There were appreciable problems which seemed resolved by appimage 980, which is great. But on adding a second Color Calibration module with a drawn mask, and re-using it in a Color balance rgb module, errors occurred. Using the option to clear all pipeline cashes, the image in the darktable sorted itself out. On pressing Escape however, the lighttable image was still wrong. On exporting, it was the incorrect image which was created as jpeg. The attached screen images show the change, the only difference is pressing Escape.
When I output I'm getting this in the Terminal window -
(AppRun.wrapped:17322): GLib-CRITICAL **: 17:18:27.553: g_date_time_unref: assertion 'datetime != NULL' failed
If I export from the darktable (correct image) rather than lighttable, unfortunately the jpeg is still wrong.
Does your problem occur with OpenCL enabled ?
I don't know
Does your problem occur with OpenCL disabled ?
Yes
Previous Ansel version that use to work
No response
Output of ansel -d all
No response
Backtrace
No response
The text was updated successfully, but these errors were encountered: