-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test workflow branch #1
base: main
Are you sure you want to change the base?
Conversation
@@ -95,8 +97,17 @@ jobs: | |||
with: | |||
kubelogin-version: 'v0.0.25' | |||
|
|||
# gets credentials for a fleet | |||
- name: Get fleet credentials | |||
if: env.FLEET == 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment applies to all env.FLEET == 'true'
expressions below as well.
I think we can use the if/else statement in Go template to achieve this without having the condition leaked to GitHub action and without the FLEET
parameter either.
For example, it could be {{ if FLEETNAME }} // do something specific for fleet {{ else }} // do something specific for AKS
Description
Please include the related issue if relevant, and motivation/context. Please also list any dependencies required for this change.
Fixes # (issue)
Feature # (details)
Type of change
How Has This Been Tested?
Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).
Checklist: