Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test workflow branch #1

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Test workflow branch #1

wants to merge 11 commits into from

Conversation

audrastump
Copy link
Owner

Description

Please include the related issue if relevant, and motivation/context. Please also list any dependencies required for this change.

Fixes # (issue)
Feature # (details)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

How Has This Been Tested?

Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).

  • Unit Test:
  • E2E Test:
  • Other Test:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

pkg/providers/azure.go Outdated Show resolved Hide resolved
pkg/providers/azure.go Outdated Show resolved Hide resolved
@@ -95,8 +97,17 @@ jobs:
with:
kubelogin-version: 'v0.0.25'

# gets credentials for a fleet
- name: Get fleet credentials
if: env.FLEET == 'true'
Copy link

@nwnt nwnt Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment applies to all env.FLEET == 'true' expressions below as well.

I think we can use the if/else statement in Go template to achieve this without having the condition leaked to GitHub action and without the FLEET parameter either.

For example, it could be {{ if FLEETNAME }} // do something specific for fleet {{ else }} // do something specific for AKS

pkg/providers/azure.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants