Require audmath>=1.4.1 to support numpy 2.0 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires the latest version of
audmathto ensure, thataudinterfacealso works withnumpy2.0.We also have to require
numpy<2.0.0when building the docs as we uselibrosain an example, which fails due to dofuuz/python-soxr#28.We cannot easily test Python 3.8 as
audbcaches created withnumpy2 cannot be read with older versions ofnumpy. As Python 3.8 reaches anyway its end of life, I decided to remove already support for Python 3.8, instead of adding workarounds for the tests.