Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle array in formatting helpers + tests #341

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

atymic
Copy link
Owner

@atymic atymic commented Apr 13, 2021

Closes #339

@atymic atymic requested a review from reliq April 13, 2021 03:13
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #341 (5f27e10) into main (6761cda) will increase coverage by 0.91%.
The diff coverage is 56.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #341      +/-   ##
============================================
+ Coverage     33.58%   34.50%   +0.91%     
- Complexity      354      357       +3     
============================================
  Files            31       31              
  Lines           789      800      +11     
============================================
+ Hits            265      276      +11     
  Misses          524      524              
Impacted Files Coverage Δ Complexity Δ
src/ApiV1/Traits/FormattingHelpers.php 16.41% <56.25%> (+16.41%) 21.00 <3.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6761cda...5f27e10. Read the comment docs.

@atymic atymic merged commit 7f43558 into main Apr 14, 2021
@atymic atymic deleted the fix/tweet-array-handling branch April 14, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormattingHelpers assume an object
2 participants