run shellcheck #97
Merged
run shellcheck #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Conrad Ludgate <oon@conradludgate.com>
|
I'm not sure why it's still not picking up the new action. Any ideas, @conradludgate ? |
|
D'oh! That's it! |
https://github.com/koalaman/shellcheck/wiki/SC1071, and the ignore: param in ludeeus/action-shellcheck only supports _directories_, not _files_. So instead, we manually add any error the shellcheck step finds in the file to the above line ...
|
Ready for review. One thing to put eyes on: this 92a74ea is fine, right? We're just checking for a status code there? |
|
Shellcheck + zsh: koalaman/shellcheck#809 |
|
Do you think you could add a comment to every ignore line? |
ellie
reviewed
May 12, 2021
ellie
requested changes
May 12, 2021
There was a problem hiding this comment.
Thanks for this! I've just got one small suggestion (as it looks like the = should not be there?)
Happy to merge once this is done 😊
Co-authored-by: Ellie Huxtable <ellie@elliehuxtable.com>
|
Thanks for catching that! I also resolved the merge conflict in install.sh. |
|
Thank you! 🚀 |
ellie
approved these changes
May 14, 2021
| printf '\neval "$(atuin init zsh)"' >> ~/.zshrc | ||
|
|
||
| curl https://raw.githubusercontent.com/rcaloras/bash-preexec/master/bash-preexec.sh -o ~/.bash-preexec.sh | ||
| printf '\n[[ -f ~/.bash-preexec.sh ]] && source ~/.bash-preexec.sh' >> ~/.bashrc | ||
| # Use of single quotes around $() is intentional here |
There was a problem hiding this comment.
Yes, they are. We want the string as is into the rc file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64