Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiline commands in fish shell #623

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

arcuru
Copy link
Sponsor Contributor

@arcuru arcuru commented Nov 19, 2022

Clean up the _atuin_bind_up function for the fish shell.

  • Gives control back to fish in search- or paging-mode
  • Correctly handles multiline commands

A user can still enter fish's search-mode by invoking up-or-search directly, so we probably want to let them do that.

Tested manually

Closes #622

Copy link
Collaborator

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks!

@conradludgate conradludgate merged commit 478af1f into atuinsh:main Nov 19, 2022
@arcuru arcuru deleted the fish-bind-up branch October 26, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't press up arrow while running multiline command in Fish without opening atuin
2 participants