Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic update checking #555

Merged
merged 9 commits into from
Oct 14, 2022
Merged

Add automatic update checking #555

merged 9 commits into from
Oct 14, 2022

Conversation

ellie
Copy link
Member

@ellie ellie commented Oct 12, 2022

Check for updates, and show a message if there is one available!

I'm going to be rolling out deletion support over several versions, as it's complicated and changes how sync and history is transferred. This way, we make it more likely that people will follow the updates on time.

My Rust is a teeny bit rustier than I'd like, it's been a little while 😞

conradludgate
conradludgate previously approved these changes Oct 13, 2022
Copy link
Collaborator

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀 🦄

atuin-client/src/settings.rs Outdated Show resolved Hide resolved
@ellie
Copy link
Member Author

ellie commented Oct 13, 2022

Any idea why the tests are failing @conradludgate?

It's not liking the api client import but I don't get why 🤔

Co-authored-by: Conrad Ludgate <conradludgate@gmail.com>
@conradludgate
Copy link
Collaborator

It's not liking the api client import but I don't get why 🤔

Ahh yeah. Since that's a sync related feature, it doesn't work in the tests which specify --no-default-features.

I split those features out a while back so we could have minimal client-only installs. It shouldn't be too hard to get it to work here either (needs_update will just always return None if the feature is disabled)

@ellie ellie merged commit f03f6e9 into main Oct 14, 2022
@ellie ellie deleted the update-check branch October 14, 2022 09:59
@ellie ellie mentioned this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants