Add Fig as an installation method to the README #459
Conversation
README.md
Outdated
| @@ -192,6 +192,14 @@ And then follow [the shell setup](#shell-plugin) | |||
| Once the binary is installed, the shell plugin requires installing. If you use | |||
| the install script, this should all be done for you! | |||
|
|
|||
| ### Fig | |||
There was a problem hiding this comment.
Could you move Fig down below the shell-specific installs please? We've tried to keep things roughly in the order of what people installing Atuin use most, and Fig is still super new
README.md
Outdated
| @@ -192,6 +192,14 @@ And then follow [the shell setup](#shell-plugin) | |||
| Once the binary is installed, the shell plugin requires installing. If you use | |||
| the install script, this should all be done for you! | |||
|
|
|||
| ### Fig | |||
|
|
|||
| [Fig](https://fig.io) adds apps, shortcuts, and autocomplete to your existing terminal. | |||
There was a problem hiding this comment.
The description here reads like an ad - I appreciate you listing your install, but our README is not the place to sell a product or boost SEO
If you could follow the pattern of our other install methods, that would be great - purely informative, letting people who already use a given shell know how to install the plugin for it
|
Hi @ellie, thanks for reviewing my PR.
Ordering by tool popularity makes sense - I addressed it in the latest commit. My reasoning for putting Fig at top was that it's a shell-agnostic installation method that works for zsh, bash, or fish - so it made sense to me to list more general install methods above less general ones (just as you put the script-installation at the top, for example).
Sorry to hear that the description felt like an ad - I removed it in the final commit. We just wanted to give a short description of what Fig is since we realize some users are not familiar with it. How do my changes look to you @ellie? |
|
Yup this is great, thank you! |
The Fig Plugin Store supports 1-click install for 400+ shell plugins. We have over 100k users, thousands of whom manage their shell configuration with Fig.
atuinis already listed in the store so we'd love to have it listed as a download method on your README.Thanks so much and please let me know if you have any questions!