Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History filter #329

Merged
merged 3 commits into from
Apr 22, 2022
Merged

History filter #329

merged 3 commits into from
Apr 22, 2022

Conversation

ellie
Copy link
Member

@ellie ellie commented Apr 22, 2022

Switch between different search modes to narrow down the history you
want - global search for all history, host for all history from your
current machine, session for the current shell session, and directory
for the current directory

The default can be configured via filter_mode

@ellie ellie force-pushed the history-filter branch 4 times, most recently from df3aeca to 18a9f5c Compare April 22, 2022 19:11
conradludgate
conradludgate reviewed Apr 22, 2022
View reviewed changes
Copy link
Collaborator

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh jeez that sql

.github/workflows/rust.yml Show resolved Hide resolved
atuin-client/src/database.rs Outdated Show resolved Hide resolved
@ellie
Copy link
Member Author

ellie commented Apr 22, 2022

This 100% highlights the fact we need to bin off SQL, or at least stop using it in this way. Hopefully a query builder or something would work, I am also not a fan of ORMs 😬

@conradludgate
Copy link
Collaborator

This 100% highlights the fact we need to bin off SQL, or at least stop using it in this way. Hopefully a query builder or something would work, I am also not a fan of ORMs 😬

Yeah, I was looking at the sqlx macros for a bit but decided that query builders really is the way to go for us

conradludgate
conradludgate previously approved these changes Apr 22, 2022
View reviewed changes
@ellie
Add history filters, and hotkey toggle
820db3b 
Switch between different search modes to narrow down the history you
want - global search for all history, host for all history from your
current machine, session for the current shell session, and directory
for the current directory

The default can be configured via `filter_mode`
@ellie
Update docs
e797f6b
@ellie ellie merged commit 508d4f4 into main Apr 22, 2022
@ellie ellie deleted the history-filter branch April 22, 2022 20:05
This was referenced Apr 22, 2022
Closed
Closed
Closed
Closed
ellie added a commit that referenced this pull request Apr 23, 2022
@ellie
Release v0.9.0
a1b1582 
89549b3 Bump uuid from 0.8.2 to 1.0.0 (#311)
831cc98 Fix typos in the docs. (#171)
7436e4f feature-flags (#328)
508d4f4 History filter (#329)
02c70de refactor (#327)
a9d1ece Added docker-compose.yml (#325)
b8bdd83 Bump clap from 3.1.10 to 3.1.11 (#323)
52a3d0c Bump tracing from 0.1.33 to 0.1.34 (#324)
79597b0 Bump clap_complete from 3.1.1 to 3.1.2 (#316)
5aca611 Allow for larger commands (#321)
9085485 tracing (#315)
98d70fb treat popos as ubuntu (#319)
d57f549 refactor commands for better separation (#313)
24e2971 Fix SQL cache query (#318)
fe05d86 Fix delete trigger (#317)
48747e3 A few minor tweaks (#314)
ed4e07d Use the count cache (#312)
6e11b8e Bump clap from 3.1.9 to 3.1.10 (#309)
44e417d Bump axum from 0.5.1 to 0.5.3 (#310)
b98a378 Add count trigger (#308)
7fe523a Bump sqlx from 0.5.11 to 0.5.13 (#305)
c5ab2a4 Bump clap from 3.1.8 to 3.1.9 (#306)
55f66c8 Bump cli-table from 0.4.6 to 0.4.7 (#297)
69279d2 Bump config from 0.13.0 to 0.13.1 (#303)
d94cdae README: add MacPorts installation instructions (#302)
f4240aa Initial implementation of calendar API (#298)
3c5fbc5 provide better error messages (#300)
bc45bab remove default db uri (#299)
4897f4a Bump rmp-serde from 0.15.5 to 1.0.0 (#264)
5b2e828 Bump directories from 3.0.2 to 4.0.1 (#246)
016386c Bump urlencoding from 1.3.3 to 2.1.0 (#208)
a95018c goodbye warp, hello axum (#296)
3b7ed7c fix env config parsing (#295)
@ellie ellie mentioned this pull request Apr 23, 2022
Merged
ellie added a commit that referenced this pull request Apr 23, 2022
@ellie
Release v0.9.0 (#334)
22a7d88 
89549b3 Bump uuid from 0.8.2 to 1.0.0 (#311)
831cc98 Fix typos in the docs. (#171)
7436e4f feature-flags (#328)
508d4f4 History filter (#329)
02c70de refactor (#327)
a9d1ece Added docker-compose.yml (#325)
b8bdd83 Bump clap from 3.1.10 to 3.1.11 (#323)
52a3d0c Bump tracing from 0.1.33 to 0.1.34 (#324)
79597b0 Bump clap_complete from 3.1.1 to 3.1.2 (#316)
5aca611 Allow for larger commands (#321)
9085485 tracing (#315)
98d70fb treat popos as ubuntu (#319)
d57f549 refactor commands for better separation (#313)
24e2971 Fix SQL cache query (#318)
fe05d86 Fix delete trigger (#317)
48747e3 A few minor tweaks (#314)
ed4e07d Use the count cache (#312)
6e11b8e Bump clap from 3.1.9 to 3.1.10 (#309)
44e417d Bump axum from 0.5.1 to 0.5.3 (#310)
b98a378 Add count trigger (#308)
7fe523a Bump sqlx from 0.5.11 to 0.5.13 (#305)
c5ab2a4 Bump clap from 3.1.8 to 3.1.9 (#306)
55f66c8 Bump cli-table from 0.4.6 to 0.4.7 (#297)
69279d2 Bump config from 0.13.0 to 0.13.1 (#303)
d94cdae README: add MacPorts installation instructions (#302)
f4240aa Initial implementation of calendar API (#298)
3c5fbc5 provide better error messages (#300)
bc45bab remove default db uri (#299)
4897f4a Bump rmp-serde from 0.15.5 to 1.0.0 (#264)
5b2e828 Bump directories from 3.0.2 to 4.0.1 (#246)
016386c Bump urlencoding from 1.3.3 to 2.1.0 (#208)
a95018c goodbye warp, hello axum (#296)
3b7ed7c fix env config parsing (#295)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradludgate conradludgate conradludgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellie @conradludgate