Fish importing #234
Merged
Fish importing #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradludgate
commented
Dec 10, 2021
set up fish init script
|
IMHO, keybinds should not a default setting |
panekj
reviewed
Dec 10, 2021
This is currently the standard behaviour of all of the shell integrations, I don't think we should handle fish any differently |
Co-authored-by: PJ <me@panekj.dev>
panekj
reviewed
Dec 10, 2021
panekj
reviewed
Dec 10, 2021
Co-authored-by: PJ <me@panekj.dev>
Co-authored-by: PJ <me@panekj.dev>
panekj
reviewed
Dec 10, 2021
Co-authored-by: PJ <me@panekj.dev>
|
Also missing |
ellie
approved these changes
Dec 11, 2021
There was a problem hiding this comment.
Amaaazing, thanks @conradludgate!
And thanks @panekj for your help too 😊 Really happy to get this issue closed off, I'll release it soon
|
So happy to see it ❤️, Thank you @conradludgate. I can't wait to see the next release ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57
So, Fish YAML is not real YAML. So there's no point bringing out a YAML parser for this. Instead, we read line by line.
We use
-at the beginning to determine whether the line is a new entry. If we find a new entry line and we've found acmd: ...value, we exit the loop and return our history item.It's pretty fault tolerant, ignoring bad lines and missing values.