-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against ancient versions of bash (3.2) where Atuin does not work. #1794
Conversation
Bash 3.2 is supported by Atuin. As far as I test it, Atuin works with both Bash 3.2/bash-preexec and Bash 3.2/ble.sh.
I guess you set
|
I did miss that, but it doesn't seem to be the default. If I run I'm also not finding much online imageabout this option. |
Also, |
(oops yeah I meant export not set) Clearing out Updated the text slightly. |
Ah, I see. Then, that makes more sense.
I see. The option was recently added.
Have you reverted it again? After force-pushing, nothing seems to be changed from the very initial version. |
Is this PR still required? Atuin does work under bash 3.2. Perhaps not as well as with later versions, but it works nonetheless. Looks like this was over some config issues? |
This PR is not required. I even think it shouldn't be merged in the current state. However, I thought it could be useful if it is updated to notify the users of the limitation instead of canceling the installation. I suggested that, and the author @fragmede seemed to accept the suggestion, but then the author reverted the applied change to the original state. I'm not sure what is the author's intent. We can wait for the author's reply. |
Thank you both! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi.
Checks
I'm on OS X, version
Sonoma 14.2.1 (23C71)
, which ships an ancient version of bash (3.2).Atuin doesn't work under bash 3.2. it runs when I hit "up", but then when I hit enter, the command doesn't get put into the line to be run if I hit enter a second time.
Of course, the first thing to do with that is to upgrade to a recent version of bash using homebrew.
Unfortunately, that doesn't always take fully, resulting in bash 3.2 getting run... sometimes.
This adds a guard to install.sh, erroring out, saying that Atuin doesn't work in bash 3.2.