Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nushell): readd up-arrow keybinding, now with menu handling #1770

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

remmycat
Copy link
Contributor

@remmycat remmycat commented Feb 25, 2024

Fixes #1025

This seems to work, see the nushell docs for until, and how it can account for the menu handling: https://www.nushell.sh/book/line_editor.html#until-type

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@remmycat
Copy link
Contributor Author

Since it's easy to test out, we should probably wait a little for feedback confirming that this fixes the issue 🙂

@arcuru
Copy link
Sponsor Contributor

arcuru commented Feb 26, 2024

Awesome! I've confirmed that this snippet works as well.

This probably needs a small matching PR in https://github.com/atuinsh/docs to remove https://github.com/atuinsh/docs/blob/a814efba030b985942c09c215122f655f36272c0/src/content/docs/configuration/key-binding.mdx#L52

I'll also ping nushell/nushell#10414 so there is a link to the solution :)

@remmycat
Copy link
Contributor Author

I see - added the docs PR :)

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

Thanks for testing @arcuru 🙏

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie ellie merged commit 593dc41 into atuinsh:main Feb 28, 2024
15 checks passed
ellie pushed a commit to atuinsh/docs that referenced this pull request Feb 28, 2024
This updates the docs in case atuinsh/atuin#1770
lands, which fixes the referenced issue
atuinsh/atuin#1025

Since this hasn't happened yet I created this as a draft - feel free to
un-draft it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nushell: atuin should not always trigger on ⬆️
3 participants