Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP package manager "composer" to list of default common subcommands #1757

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

KorvinSzanto
Copy link
Contributor

Composer is the de facto standard dependency manager for PHP, similar to NPM for node. This PR updates the common_subcommands_default so that composer is included by default like similar tools for node.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

ellie
ellie previously approved these changes Feb 22, 2024
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie
Copy link
Member

ellie commented Feb 22, 2024

ah also looks like this needs a cargo fmt

@KorvinSzanto
Copy link
Contributor Author

Added a commit that runs cargo fmt and sorts the entries

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you

@ellie ellie merged commit d7582b6 into atuinsh:main Feb 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants