Aaron/lesson6 tasks #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rder to implement the phi labeling correctly, since that's what tells me what blocks might have assigned to a variable
…ith our control flow for variable renaming. This may be fixable by just building a lookup table of all of our names for each variable coming out of a block, but that seems a little hacky, so I'm going to try the class pseudocode
…ll use my reachability definitions in writing the phi nodes. Unfortunately I started fixing things to handle arguments without committing first, and that code wound up touching surprisingly many things so I can't really split it into two commits at this point
…e -- if the definition is coming from anything other than the entry block, we can just add another phi entry for the entry block that says to set it to undefined if the entry block is the most recently exectued. That way, all defined variables still get defined, and all undefined variables are still undefined
…that I can implement ssa on a function level
… in a ton of places if it changes
…ld be undefined, so actually add the __undefined behavior rather than asserting false
…ets used, and we'll skip adding it
…yet, then we don't try to do it and crash
…ecessor to the tree before asking if its there
…er to the block that's running. If we're in the entry block and trying to talk about an argument, we need to create a new entry block to talk about, and otherwise we need to point to our successors instead of the block that's currently running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for Lesson 6!