Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement improved Delay, covering full u32 range #14

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

jamesmunns
Copy link

@TeXitoi
Copy link

TeXitoi commented Oct 11, 2018

All these copy and pasted delay implementations seems wrong to me. I think this should be addressed in embedded_hal, providing a way to wrap any timer in such a delay function.

@jamesmunns
Copy link
Author

I generally agree with you, the issue up to now was the different ways that the main sysclock is exposed in the different HALs.

That being said, I think rust-embedded/embedded-hal#103 is a move in the right direction.

@wez
Copy link
Member

wez commented Oct 14, 2018

Thanks; tested this with the blinky example for metro m0 using a 1s interval and it no longer faults like the old impl used to :-p

@wez wez merged commit 5452041 into atsamd-rs:master Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants