Update #133
Merged
Update #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (#3378) Add support for combined listings and 2k variants
* fix product modal not showing variant image * reuse existing const var as per feedback
* Added duties inclusive text to PDP and Cart page --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
…r and clean up network requests (#3480)
…ing product-info class and migrating product-update specific logic out of the VariantSelects class. A product wrapper enables children to more trivially perform global updates by providing a heirarchical "namespace"--i.e. child publishes event, parent captures and declaratively updates other children VS child updates siblings. By extracting the VariantSelects onChange logic to use this pattern, VariantSelects is able to be a single-purpose class, it is easier to understand why siblings are updated, and we were able to eliminate some really gross logic that handled variant change updates differently depending on the wrapping context. (#3289) Refetch entire page on product swap Remove unused unsubscriber function Stability improvements for quick-add modal PR feedback - fixed padding + minor tweaks Un-privatize class methods for consistency with the rest of Dawn Move css to be in section-main-product.css
* Use translation keys for default values in liquid files * Update 10 translation files * Update 10 translation files * Update 10 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
* Dedupe IDs when replacing content * Dedupe form attributes
* Updates Dawn to use the new filter * Add support for article structured data
* (#3492) Fix volume pricing message jumpiness when switching between combined listings; update page title when switching between combined listings; fix unselected option value bug in Safari * Update ID deduplication for quick add modal
* Centre 'view cart' label in quick add modal. * Remove extra spacing at the bottom of quick order modal. * Fix the extra underlined space between the 'view full details' text and the arrow. * Make the product title a link to the product page. * Tweak breakpoints for consistently when the viewport is exactly 989 or 990 px wide
…nge (#3496) * adds theme toggle for avatar widget to allow opt-out without code change * resolve spacing differences when account-icon is present in the DOM * Update 15 translation files * Update 5 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
…es, to be injected into components not naturally on the DOM (#3503)
…nt instead of a variant change start event, defer variant info until section rendering API request comes back (#3495) Only update media when the selection has an associated variant
* Deduplicate the option value IDs after option value selection changes in quick add modal
* Add gigantic heading size. * Use global translations in multirow. * Standardize heading font size offerings. * Change "Gigantic" to "Giant" * Set line height for new font size. * Update 10 translation files * Decrease Giant font size, update line height too. * Define line height for hxl. * Fix incorrect reference. * Set large line height to 1.1 all the time. * Adjust `vw` value in clamp so that the Giant font size is always larger than the Extra Large. * Change string to "Extra Extra Large" * Change text case. * Update 13 translation files * Update 4 translation files * Update 2 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
* Limit the number of stylesheets on the page * Apply suggestions from code review Co-authored-by: Ludo <ludo.segura@shopify.com> * Improve the logic and wording a bit --------- Co-authored-by: Ludo <ludo.segura@shopify.com>
* [Product] Zoom on hover fix on variant change (#3511) * Zoom on hover fix on variant change * add conditional * Add early return in updateQuantityRules function if no quantity selector is present (#3515) * Fix bug where request url contains duplicated params when switching before the prior response is returned (#3521) * Fixes bug where image flashes when switching to variant with the same featured image; fixes bug where variant without featured image would fallback to the product image (#3516) Fix issue with thumbnail not updating * Fixed bug when reading selected option values. Removed unused script tag containing variant json. (#3520) * escape titles that weren't (#3514) * Support multiple product templates for the same combined listing (#3526) * Updated quick order list to rely on the variant title field (#3528) * Release15fix (#3531) * Revert "Update from Shopify for theme dawn/release/15.0.0" This reverts commit 5b20d89. * Revert "Update from Shopify for theme dawn/release/15.0.0" This reverts commit f0b822d. * Revert "Update from Shopify for theme dawn/release/15.0.0" This reverts commit 64e1d8e. * Revert "Update from Shopify for theme dawn/release/15.0.0" This reverts commit a8a7529. --------- Co-authored-by: Ludo <ludo.segura@shopify.com> Co-authored-by: Arthur <48017311+Roi-Arthur@users.noreply.github.com> Co-authored-by: Lars Hoffbeck <lars.hoffbeck@shopify.com> Co-authored-by: shopify[bot] <79544226+shopify[bot]@users.noreply.github.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
* Fixed issues when header is hidden * Fixed predictive search on search page * Made it so that the drawer still shows up
…ters and this renders undesirably. (#3567)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Why are these changes introduced?
Fixes #0.
What approach did you take?
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist