feat: fix outdated get_expiration_dates function
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this PR merged, I forked this project and fixed a bunch of the functions in my repository. If you want to use the fixed package, you can also use |
|
This PR should be merged! Thanks. |
|
Also congrats for the fix on lxml_html_clean I also noticed that and struggled with the fix. I wish I had seen this PR before. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_expiration_datesfunction due to the Yahoo Finance page updated, which means theget_expiration_datesfunction is outdated, FYI: https://finance.yahoo.com/quote/IBM/options?p=IBMget_expiration_datesfunction to ensure the correctness.lxml_html_cleaninrequires.txtaccording to the error message:lxml.html.clean module is now a separate project lxml_html_clean.Metadata-VersionandVersion.