Add support for unregister/1
#364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
requested changes
Oct 16, 2022
UncleGrumpy
force-pushed
the
unregister
branch
from
31e5b97
to
bcb425d
Compare
bettio
requested changes
Oct 18, 2022
bettio
approved these changes
Oct 19, 2022
bettio
requested changes
Oct 20, 2022
UncleGrumpy
force-pushed
the
unregister
branch
6 times, most recently
from
733a4ec
to
cdb26de
Compare
bettio
requested changes
Oct 21, 2022
UncleGrumpy
force-pushed
the
unregister
branch
8 times, most recently
from
ca6fff6
to
3da3a81
Compare
added 6 commits
October 22, 2022 16:38
Signed-off-by: Winford <dwinford@pm.me>
Signed-off-by: Winford <dwinford@pm.me>
Adds checks that pid is an active process, atom is not already registered to a process, and the atom name is not the "undefined" atom. Signed-off-by: Winford <dwinford@pm.me>
Closes issue atomvm#358. Signed-off-by: Winford <dwinford@pm.me>
`register/2` and `unregister/1` functions are tested for correct returns, functionality, and proper error returns. Signed-off-by: Winford <dwinford@pm.me>
Exposes a native elixir interface to unregister/1. Signed-off-by: Winford <dwinford@pm.me>
UncleGrumpy
force-pushed
the
unregister
branch
from
3da3a81
to
e7a134e
Compare
bettio
added a commit
that referenced
this pull request
Oct 23, 2022
Add support for `unregister/1` These changes add `unregister/1` as well as some minor enhancements to error returns to match expected otp behavior, and address the TODOs in the `nif_erlang_register_2` function in src/libAtomVM.nifs.c. Also adds test for `register/2` and `unregister/1` return values, functionality, and error returns - designed to test the conditions raised in the previously addressed TODOs (existing process pid, not already registered, not the atom "undefined"). Closes issue #358 These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
|
Merged with some minor git history and CHANGELOG cleanups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add
unregister/1as well as some minor enhancements to error returns to match expected otp behavior, and address the TODOs in thenif_erlang_register_2function in src/libAtomVM.nifs.c. Also adds test forregister/2andunregister/1return values, functionality, and error returns - designed to test the conditions raised in the previously addressed TODOs (existing process pid, not already registered, not the atom "undefined").Closes issue #358
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later