Improvements #1
Improvements #1
Conversation
There was a problem hiding this comment.
@RunDevelopment hey this looks good, all the important parts are there! Thanks for cleaning up this stuff to fit with core better/sorry if it was a bit of a style mess (ternary operators, i know, i know, i overuse'em =) Your changes are much more stylistically in line with the prism core upon further study, and I see what you are going for now, so, noted! I suppose I could've studied you're preferred style a bit before just sticking my plugin code in there hehe. I've never peeked in to the Prism API/core build before this last week so this was fun and I am grateful for that -- so thanks 🙏
I'm stoked for this feature, thanks for all the back and forth making it happen. I wanted to implement it because it seems like one of those things that should've always been there. I hope if this is baked in to a release people use it!
* add data-range to file-highlight * Add data-range to file-highlight * gulp? * gulp? * Improvements (#1) * Removed package-lock * Improved File highlight * Tutorials from comments - first commit * style.css messing up nested lists * un-es6 Snarkdown * more un-es6 snarkdown * gulped
@atomize I made a few improvements to your branch. Please look over them and tell me if you found any mistakes.
A few of the changes:
Loading...text is displayed again.data-src-loaded.We generally don't commit
package-lock.json, so I deleted it.