Skip to content
This repository has been archived by the owner on Nov 9, 2024. It is now read-only.

fix: filter out duplicate plugins #626

Merged
merged 1 commit into from
Oct 27, 2019
Merged

fix: filter out duplicate plugins #626

merged 1 commit into from
Oct 27, 2019

Conversation

atomiks
Copy link
Owner

@atomiks atomiks commented Oct 27, 2019

  • Addons were .concating defaultProps.plugins unnecessarily since tippy() does it.
  • Duplicate plugins should be filtered out at createTippy() for extra safety.

Most exported plugins when duplicated don't cause issues but make performance worse.

unique() could use [...new Set(plugins)] which is faster I think, but I'm not sure of how well-supported it is, best to use this one?

@atomiks
Copy link
Owner Author

atomiks commented Oct 27, 2019

Also something odd is the linter is not longer complaining about lack of return type for callback functions like .filter() (which is way less noisy and better, maybe we can remove all of them in another PR).

@atomiks atomiks merged commit cdc01d8 into master Oct 27, 2019
@atomiks atomiks deleted the fix/duplicate-plugins branch October 27, 2019 01:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant