-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset resource after exiting edit page without saving. #906
Comments
Some thoughts: Form fields (in the edit page) should not update the A refresh after navigating away should fix OPs issue, but it does not fix the underlying issue. Perhaps the |
I don't really see a problem with the store being updated. It makes it relatively simple to work with complex shared data throughout the app. Using some kind of clone of the resource or a separate object with values kind of goes against the read/write nature of resources and AtomicData. Refreshing the resource when the edit form unmounts is also a lot simpler and completely bypasses other issues like dealing with serverside updates of the resource that can introduce merge conflicts with the cloned data. |
* #896 Fix double tap on ios + move new resource buttons * #893 Fix tables not working from different server * Tweak new resource buttons appearance * Change ulid to ulidx lib to support non-secure contexts * Fix build issue in js cli * Fix default ontology not generating on first server setup * Fix resource-array props not removed when input is empty * Fix dropdowns jumping * Add TagPage * Various UI improvements * Fix type/lint errors * #906 Reset resource after cancel edit * Update crossfetch for better node compatibility * #910 Remove Crossfetch and fix lexical scope for client.fetch * Fix indicator jumping when scrolling table with keyboard --------- Co-authored-by: Polle Pas <polleps@gmail.com> Co-authored-by: Joonas Lipping <lippinj@outlook.com>
When editing a resource via the default edit view changes will stay on the resource even when navigating away. The changes are not persisted and are gone when the user refreshes but not when navigating to a different page. This might give the impression the resource is saved to the server and can lead to unintentional data loss.
We should make it so that when the user leaves the edit page the resource gets refreshed so it shows its state from before it was edited.
The text was updated successfully, but these errors were encountered: