Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve @tomic/lib search API #840

Closed
Polleps opened this issue Feb 8, 2024 · 0 comments · Fixed by #839
Closed

Improve @tomic/lib search API #840

Polleps opened this issue Feb 8, 2024 · 0 comments · Fixed by #839
Assignees
Labels
@tomic/lib @tomic/lib

Comments

@Polleps
Copy link
Member

Polleps commented Feb 8, 2024

Using Atomics full text search feature with @tomic/lib could be better.

Currently it's not very straightforward

const subject = buildSearchSubject(
  serverUrl,
  query,
);

const searchResource = await this.store.fetchResourceFromServer(subject, {
  noWebSocket: true,
});

const results = searchResource.get(server.properties.results);

Something like this would be a lot better:

const results = await store.search(query);
@Polleps Polleps added the @tomic/lib @tomic/lib label Feb 8, 2024
@Polleps Polleps self-assigned this Feb 8, 2024
Polleps added a commit that referenced this issue Feb 9, 2024
joepio pushed a commit that referenced this issue Mar 21, 2024
joepio pushed a commit that referenced this issue Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@tomic/lib @tomic/lib
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant