Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repurpose Validate #61

Open
joepio opened this issue Jan 3, 2021 · 2 comments
Open

Repurpose Validate #61

joepio opened this issue Jan 3, 2021 · 2 comments

Comments

@joepio
Copy link
Member

joepio commented Jan 3, 2021

The validate function used to be handy, as the store contained (unvalidated) string representations of atoms. Now, however, it only contains valid data, and Validate kind of lost its purpose. Perhaps I should remove it entirely, but It also had its use. It was able to detect multiple issues with some graph, and generate a report. Now, it throws an error as soon as it detects one.

@joepio
Copy link
Member Author

joepio commented Jan 23, 2021

I've changed error handling a couple of commits ago to improve the /validate endpoint. However, it now returns an error as soon as it encounters one, instead of telling how many errors there are. I'm not sure if these reports with multiple errors actually have that much benefit. I'm also considering dropping AD3 for another serialization format (#79).

@joepio
Copy link
Member Author

joepio commented Mar 23, 2022

#333 is related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant