Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate JSON-AD (endpoint + CLI option) #333

Open
1 of 3 tasks
joepio opened this issue Mar 17, 2022 · 1 comment
Open
1 of 3 tasks

Validate JSON-AD (endpoint + CLI option) #333

joepio opened this issue Mar 17, 2022 · 1 comment

Comments

@joepio
Copy link
Member

joepio commented Mar 17, 2022

I used to have an endpoint for this (when the front-end was generated server-side, and type checking sucked) #28 , but now I don't. Time to change this. See docs issue: atomicdata-dev/atomic-data-docs#110

How should validate-json-ad work? It takes one argument, a json-ad string, and returns an error if encountered. Parses it, checks datatypes, returns error. Should it also check every mentioned URL, every property, to see if they are still online? Seems a bit much. Maybe if I add it as an option, but that would not be necessary for the first version. I think the existing parse-json-ad stuff already does everything... So I guess all that I need to do is add the Endpoint and CLI option. Easy!

  • Add the validate functionality to atomic_lib. (not needed, we have parse!)
  • Add an Endpoint to atomic_server, that accepts a JSON-AD string (or URL) and returns a message.
  • Add a CLI command for validating JSON input (I think with a pipe command, not sure how to do this, but it's probably easy with clap, so I can do grep myfile.json-ad | atomic-cli validate).
@joepio joepio changed the title JSON-AD Validate method Validate JSON-AD (endpoint + CLI option) Mar 17, 2022
@joepio
Copy link
Member Author

joepio commented Apr 28, 2022

I think #390 may be the right place to fix this. At least, most of the logic should be shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant