Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose session max size #220

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Expose session max size #220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa826d7
Expose session max size
wizz-wallet-dev Jun 25, 2024
56c0499
Add comments
wizz-wallet-dev Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions electrumx/server/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ def __init__(self, coin=None):
self.session_timeout = self.integer("SESSION_TIMEOUT", 600)
self.session_group_by_subnet_ipv4 = self.integer("SESSION_GROUP_BY_SUBNET_IPV4", 24)
self.session_group_by_subnet_ipv6 = self.integer("SESSION_GROUP_BY_SUBNET_IPV6", 48)
self.session_max_size_http = self.integer("SESSION_MAX_SIZE_HTTP", 1024**2)
self.session_max_size_ws = self.integer("SESSION_MAX_SIZE_WS", 1024**2)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the implied default value.

self._check_and_fix_cost_limits()
self.enable_rate_limit = self.boolean("ENABLE_RATE_LIMIT", True)

Expand Down
10 changes: 8 additions & 2 deletions electrumx/server/session/session_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ async def _start_servers(self, services):
cors_middleware(self),
error_middleware(self),
request_middleware(self),
]
],
client_max_size=self.env.session_max_size_http
)
handler = HttpSession(self, self.db, self.mempool, self.peer_mgr, kind)
await handler.add_endpoints(app.router, SESSION_PROTOCOL_MAX)
Expand Down Expand Up @@ -184,7 +185,12 @@ async def _start_servers(self, services):
session_factory = partial(session_class, self, self.db, self.mempool, self.peer_mgr, kind)
host = None if service.host == "all_interfaces" else str(service.host)
try:
self.servers[service] = await serve(session_factory, host, service.port, ssl=sslc)
if service.protocol in ("ws", "wss"):
self.servers[service] = await serve(
session_factory, host, service.port, ssl=sslc, max_size=self.env.session_max_size_ws
)
else:
self.servers[service] = await serve(session_factory, host, service.port, ssl=sslc)
except OSError as e: # don't suppress CancelledError
self.logger.error(f"{kind} server failed to listen on {service.address}: {e}")
else:
Expand Down
Loading