Skip to content

Commit

Permalink
instrument skip all
Browse files Browse the repository at this point in the history
  • Loading branch information
jorgeantonio21 committed Oct 4, 2024
1 parent 48b8cbc commit 986c723
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion backends/vllm/src/block_allocator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ impl BlockAllocator {
}

impl BlockAllocator {
#[instrument(skip(self))]
/// Allocates a new physical block from the pool of free blocks.
///
/// # Returns
Expand Down
2 changes: 1 addition & 1 deletion backends/vllm/src/block_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ impl BlockSpaceManager {
/// - Returns `BlockSpaceManagerError::EmptySequence` if the sequence has no blocks.
/// - Returns `BlockSpaceManagerError::AppendSlotError` if trying to allocate more than one block at a time.
/// - Propagates errors from block allocation, freeing, or lock operations.
#[instrument(skip(self))]
#[instrument(skip_all)]
pub fn append_slots(
&mut self,
sequence: RwLockReadGuard<Sequence>,
Expand Down
4 changes: 2 additions & 2 deletions backends/vllm/src/sequence.rs
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ impl SequenceData {
/// * Traces the update operation.
/// * Logs debug information about the sequence state.
/// * Logs an error if the update would exceed the total sequence length.
#[instrument(skip(self))]
#[instrument(skip_all)]
pub fn update_num_computed_tokens(
&mut self,
num_new_computed_tokens: usize,
Expand Down Expand Up @@ -1139,7 +1139,7 @@ impl SequenceGroup {
///
/// This method is instrumented with tracing. It logs a trace event when adding the token
/// and an error event if the sequence is not found.
#[instrument(skip(self))]
#[instrument(skip_all)]
pub fn add_token_id_to_seq(
&self,
sequence_id: u64,
Expand Down

0 comments on commit 986c723

Please sign in to comment.