This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Allow specs to pass on Windows #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -376,7 +379,8 @@ describe "Notifications", -> | |||
| a + 1 | |||
| catch e | |||
| # Pull the file path from the stack | |||
| filePath = e.stack.split('\n')[1].match(/\(([^:]+)/)[1] | |||
| # For Windows we have to ignore the starting drive letter (eg C:\) | |||
| filePath = e.stack.split('\n')[1].match(/\(((\w:\\)[^:]+|([^:]+))/)[1] | |||
There was a problem hiding this comment.
Should I split this up into an unless/else block?
|
Seems legit. 🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple enough 😄. The only thing left to do is an annoying issue where the dev tools will pop up with
Uncaught Error: EISDIR: illegal operation on a directory, read, though I'm not sure if that happens on all platforms or not.EDIT: Yup, that happens on all platforms. Is there any way to suppress the dev tools from popping up there?
In addition, the specs on Windows are considerably less robust since everything is testing for
git.io/catsinstead of the actual issue URL. Should I just force the platform to be Darwin like I did on line 508?/cc @benogle