Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Support more languages #4

Closed
juh2 opened this issue Aug 30, 2014 · 11 comments
Closed

Support more languages #4

juh2 opened this issue Aug 30, 2014 · 11 comments

Comments

@juh2
Copy link

juh2 commented Aug 30, 2014

From a discussion here (https://discuss.atom.io/t/spelling-in-english-only/11819) I guess that node-spellchecker does not support other languages beside en_US

Please add more languages.
@donlencho
Copy link

+1
Basic feature that would be greatly appreciated!
Big missing point for Atom for me for the moment.
I'm using Ubuntu and Linux Mint with French as my system default but the spell check works in English only.

@despairblue
Copy link

👍

1 similar comment
@julien-noblet
Copy link

👍

@despairblue
Copy link

It seems @paulcbetts changes will solve this, see #6 and #7

Unless I misunderstood the PRs. I wonder if it also works on linux 😟

@anaisbetts
Copy link
Contributor

@despairblue It will work on Linux, but you've got to manage shipping the Hunspell dictionaries yourself (or more likely, track down where on the system they're storing the Hunspell dictionaries)

@despairblue
Copy link

@paulcbetts awesome, that's still way better the status quo 👏

@juh2
Copy link
Author

juh2 commented Mar 19, 2015

hunspell -D shows that I use the german dictionary, but in Atom I still have the english dictionary only.

@ghost
Copy link

ghost commented Jul 22, 2015

A support for other languages (e.g. German) would be great

@anaisbetts
Copy link
Contributor

This is fixed in this package, now Atom needs to use the multi-language features that node-spellchecker exposes

@donlencho
Copy link

So is this being worked on in Atom to integrate it? I'm not sure I get what needs to be done for this to be usable. Thank you.

@Yaco
Copy link

Yaco commented Sep 15, 2015

👍

@juh2 juh2 mentioned this issue Feb 5, 2016
Closed
@mkaz mkaz mentioned this issue Mar 11, 2016
Merged
soundar-m pushed a commit to soundar-m/node-spellchecker that referenced this issue May 15, 2020
@goddessfreya
Squashed commit of the following:
39fdca5 
commit 0c83612
Merge: 2c0d135 5cbdece
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:04:18 2019 -0700

    Merge pull request atom#4 from goddessfreya/Add-Github-actions

    Add Github actions

commit 5cbdece
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:01:01 2019 -0700

    Delete appveyor.yml

commit 4ddcbd3
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:00:49 2019 -0700

    Delete .travis.yml

commit c6f6c63
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 17:57:45 2019 -0700

    Update nodejs.yml

commit 84bccbd
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 17:55:23 2019 -0700

    Update nodejs.yml

commit f6720ea
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 17:50:59 2019 -0700

    Update nodejs.yml

commit 514a3f9
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 17:31:31 2019 -0700

    Add Github actions

Signed-off-by: Freya Gentz <zegentzy@protonmail.com>
soundar-m pushed a commit to soundar-m/node-spellchecker that referenced this issue May 15, 2020
@goddessfreya
Squashed commit of the following:
3d27d36 
commit 84b6708
Merge: fef5593 1a0243e
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 19:43:16 2019 -0700

    Merge pull request atom#6 from goddessfreya/goddessfreya-patch-1

    Add clang testing

commit 1a0243e
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 19:37:34 2019 -0700

    Update nodejs.yml

commit 18e838f
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 19:35:27 2019 -0700

    Delete package-lock.json

commit d17cf27
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 19:22:57 2019 -0700

    Update nodejs.yml

commit 81c5ae6
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 19:12:42 2019 -0700

    Update nodejs.yml

commit 2db0f18
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:56:33 2019 -0700

    Update nodejs.yml

commit 855c3c1
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:49:38 2019 -0700

    Update nodejs.yml

commit f80be0a
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:38:49 2019 -0700

    Update nodejs.yml

commit 3c52d66
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:35:04 2019 -0700

    Update nodejs.yml

commit 5fe3493
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:34:31 2019 -0700

    Update nodejs.yml

commit 8c41771
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:34:05 2019 -0700

    Update nodejs.yml

commit 5bd03fe
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:33:49 2019 -0700

    Update nodejs.yml

commit aab4c50
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:33:35 2019 -0700

    Update nodejs.yml

commit 0e6f86f
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:30:31 2019 -0700

    Update nodejs.yml

commit fef5593
Merge: 0c83612 e99e477
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:16:48 2019 -0700

    Merge pull request atom#5 from abetomo/fix_deprecated_callback

    Fix deprecated callback

commit 0c83612
Merge: 2c0d135 5cbdece
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:04:18 2019 -0700

    Merge pull request atom#4 from goddessfreya/Add-Github-actions

    Add Github actions

commit 5cbdece
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:01:01 2019 -0700

    Delete appveyor.yml

commit 4ddcbd3
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 18:00:49 2019 -0700

    Delete .travis.yml

commit c6f6c63
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 17:57:45 2019 -0700

    Update nodejs.yml

commit 84bccbd
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 17:55:23 2019 -0700

    Update nodejs.yml

commit f6720ea
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 17:50:59 2019 -0700

    Update nodejs.yml

commit 514a3f9
Author: Freya Gentz <zegentzy@protonmail.com>
Date:   Thu Dec 19 17:31:31 2019 -0700

    Add Github actions

commit e99e477
Author: abetomo <abe@enzou.tokyo>
Date:   Thu Jul 5 10:25:35 2018 +0900

    Fix deprecated callback

    The following warning.

    ```
    ../src/worker.cc: In member function ‘virtual void
    CheckSpellingWorker::HandleOKCallback()’:
    ../src/worker.cc:44:25: warning: ‘v8::Local<v8::Value>
    Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated
    [-Wdeprecated-declarations]
       callback->Call(2, argv);
    ```

Signed-off-by: Freya Gentz <zegentzy@protonmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@anaisbetts @Yaco @despairblue @juh2 @donlencho @julien-noblet