This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
feat(ruby.cson) support quoted heredoc literals #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this project and considering my PR!
Description of the Change
Ruby supports quoted heredocs:
But they aren't captured by the current grammar. This change adds quotes to the heredoc regexps so that they'll be properly tokenized.
Alternate Designs
No alternate deisgns were considered.
Benefits
We use single-quoted heredocs to assert that interpolation is not possible. This is a security check: interpolation can lead to various injection bugs.
Embedded code is not highlighted right now:
But after this change, it will be highlighted!
Possible Drawbacks
Added complexity to the heredoc regexp.
Applicable Issues
I didn't find any.