This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Highlighting embedded XML in HEREDOC block #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infininight
reviewed
May 30, 2017
grammars/ruby.cson
Outdated
| 'beginCaptures': | ||
| '0': | ||
| 'name': 'punctuation.definition.string.begin.ruby' | ||
| 'contentName': 'source.xml' |
There was a problem hiding this comment.
This should be text.xml instead of source.xml, same on line 1468.
There was a problem hiding this comment.
Why? Is there any difference between text.xml and source.xml here?
There was a problem hiding this comment.
The scopeName of language-xml is text.xml.
There was a problem hiding this comment.
Ah, I see. I'll fix it asap
|
@50Wliu fixed |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
It enables highlighting embedded XML in HEREDOC block. I personally work with a lot of XML nowadays so I hope someone else than me can benefit of that as well 🙃
Alternate Designs
No
Benefits
It's possible to see XML syntax in HEREDOC block
Possible Drawbacks
Unknown
Applicable Issues
Unknown