This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Highlight embedded graphql #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50Wliu
suggested changes
Jan 11, 2017
| 'beginCaptures': | ||
| '0': | ||
| 'name': 'punctuation.definition.string.begin.ruby' | ||
| 'contentName': 'source.sql' |
| 'include': '#interpolated_ruby' | ||
| } | ||
| { | ||
| 'include': 'source.sql' |
There was a problem hiding this comment.
I do believe you meant source.graphql here?
rmosolgo
force-pushed
the
embedded-graphql
branch
from
8a2c4f9
to
063fe44
Compare
|
😆 Sorry about that. I was having a hard time testing out the changes locally, and I ended up with two different copies of the source. Apparently I pushed the wrong one! Force-pushed with corrections. |
50Wliu
approved these changes
Jan 11, 2017
|
Thanks! |
|
Hi, is there a release schedule for this project? I'm looking forward to this feature but I'm happy to wait if a release is planned sometime in the future. |
|
It's currently planned to be included in the Atom 1.15.0 release. We don't publish release dates, however. |
|
Thanks for the info, I'll keep an eye out for that Atom release! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
I recently discovered that language-ruby will highlight SQL inside
<<-SQLheredoc blocks. Cool!I often use
<<-GRAPHQLto write inline GraphQL queries, so I thought, maybe I can modify language-ruby to highlight GraphQL within those blocks.This PR adds GraphQL highlighting within
<<-GRAPHQLheredoc blocks, as shown above.Alternate Designs
I didn't consider alternate designs, I just copied and modified one of the other heredoc highlighters.
Benefits
GraphQL users can have highlighted GraphQL inside their Ruby files.
Possible Drawbacks
This introduces a maintenance burden: more lines of code means more things that can break 😬
This heredoc highlighter is not tested. I didn't find tests for the others, either. Are there any?
Applicable Issues
Fixes #173
Thanks for considering this change!